Projects / sysstat / Comments

Comments for sysstat

02 Sep 2007 02:40 godard

Re: report sar7.16 problem and attach patch for it
Thanks for this patch. It has been included in sysstat 8.0.0.

02 Aug 2007 00:30 yuyongcong

report sar7.16 problem and attach patch for it
Hello, Mr.Sebastien Godard .

When I used sar7.16,I found a problem.

After adding the parameters "-s 23:59:45 -e 00:00:15",it means sar will read the records at 23:59:45~00:00:15 from sarfile,but

the result is that sar only read the records at 23:59:45-23:59:55 from sarfile,the records after 00:00:00 didn't read from sarfile.

I have made a patch to solve the problem.

To repeat this problem,you could do as following:

Step1:run the script

----------------------------------------------------------------------

#!/bin/sh

DATE=`date +%m%d%H%M%S`

date -s 23:59:45

echo "Now time has been set "`date`

echo "Sar starts to write in sar.$DATE "

sar 5 10 -o ./sar.$DATE

hwclock --hctosys

-----------------------------------------------------------------------

After running,it will create a sarfile.

Step2:read created sarfile

Sar Version: sar 7.16

[root@localhost sysstat-7.1.6]# sar -V

sysstat version 7.1.6

(C) Sebastien Godard (sysstat <at> wanadoo.fr)

[root@localhost sysstat-7.1.6]# sar -f testsar/sar.0810000205

Linux (localhost.localdomain) 08/10/2007

23:59:45 CPU %user %nice %system %iowait %steal %idle

23:59:50 all 4.19 0.00 6.59 0.00 0.00 89.22

23:59:55 all 8.02 0.20 11.42 0.00 0.00 80.36

00:00:00 all 5.59 0.00 9.58 0.00 0.00 84.83

00:00:05 all 4.60 0.40 6.60 0.00 0.00 88.40

00:00:10 all 4.61 0.00 6.61 0.00 0.00 88.78

00:00:15 all 3.99 0.20 9.58 2.20 0.00 84.03

00:00:20 all 4.80 0.20 8.20 0.60 0.00 86.20

00:00:25 all 4.39 0.20 6.39 0.00 0.00 89.02

00:00:30 all 4.21 0.00 7.62 0.00 0.00 88.18

00:00:35 all 4.39 0.20 7.39 0.20 0.00 87.82

00:00:40 all 4.20 0.20 7.40 0.00 0.00 88.20

00:00:45 all 7.80 0.00 9.20 1.00 0.00 82.00

Average: all 5.06 0.13 8.05 0.33 0.00 86.42

Created sarfile starts with 23:59:45 ends with 00:00:45

Step3:Problem turn out

[root@localhost sysstat-7.1.6]# sar -f testsar/sar.0810000205 -s 23:59:45 -e 00:00:15

Linux (localhost.localdomain) 08/10/2007

The bug can be fixed with the following patch:

Signed-off-by: "Yu Yongcong" <yuyc@cn.fujitsu.com>

--- sysstat-7.1.6/sar.c.orig 2007-08-14 08:09:28.000000000 +0800

+++ sysstat-7.1.6/sar.c 2007-08-14 10:13:47.000000000 +0800

@@ -840,6 +840,13 @@

set_timestamp(!curr, cur_time[!curr], 16);

/* Set current timestamp */

set_timestamp(curr, cur_time[curr], 16);

+

+ if (tm_start.use && file_stats[!curr].ust_time

+ && (file_stats[curr].ust_time > file_stats[!curr].ust_time)

+ && (file_stats[curr].hour < file_stats[!curr].hour)) {

+ file_stats[curr].hour += 24;

+ rectime.tm_hour += 24;

+ }

/* Check time (2) */

if (use_tm_start && (datecmp(&rectime, &tm_start) < 0))

@@ -1622,6 +1629,9 @@

((interval < 0) && !from_file[0] && !to_file[0]))

set_default_file(&rectime, from_file);

+ if (tm_start.use && tm_end.use && (tm_end.tm_hour < tm_start.tm_hour))

+ tm_end.tm_hour += 24;

+

/*

* Check option dependencies

*/

Here is the output after the fix:

[root@localhost sysstat-7.1.6]#sar -f testsar/sar.0810000205 -s 23:59:45 -e 00:00:15

Linux (localhost.localdomain) 08/10/2007

23:59:45 CPU %user %nice %system %iowait %steal %idle

23:59:50 all 4.19 0.00 6.59 0.00 0.00 89.22

23:59:55 all 8.02 0.20 11.42 0.00 0.00 80.36

00:00:00 all 5.59 0.00 9.58 0.00 0.00 84.83

00:00:05 all 4.60 0.40 6.60 0.00 0.00 88.40

00:00:10 all 4.61 0.00 6.61 0.00 0.00 88.78

00:00:15 all 3.99 0.20 9.58 2.20 0.00 84.03

Average: all 5.16 0.13 8.40 0.37 0.00 85.94

That's all.

Best Regards.

28 Dec 2004 13:18 godard

Re: fix for spec file
OK: spec file updated with sysstat 5.1.4.

17 Dec 2004 13:30 godard

Re: compile errors on 2.6


> Hey, just tried to do an rpmbuild

> --rebuild on 5.1.3

>

> noticed that the build failed because

> MAX_BLKDEV isn't defined for 2.6

> kernels, for some reason it was removed

> from major.h.

Yes: MAX_BLKDEV was removed from linux/major.h in 2.6 kernels. Sysstat 5.1.4 has been updated to take this into account.

17 Dec 2004 13:26 godard

Re: after all that, sar doesn't work


> pseries-loaner:/usr/src/packages/SOURCES/sysstat-5.1.3

> # ./sar -u 2 5

> exec: No such file or directory

>

This is because sar tries to launch its data collector (sadc) and doesn't find it. Enter "make install" after compiling to install each component in its directory before using sar.

16 Dec 2004 16:33 go_jesse

after all that, sar doesn't work
pseries-loaner:/usr/src/packages/SOURCES/sysstat-5.1.3 # ./sar -u 2 5

exec: No such file or directory

dunno whats up, sadc wouldn't start either. sar dies in sa_read right after trying to read from stdin.

16 Dec 2004 13:59 go_jesse

fix for spec file
I have rpm 4.1 and it complains loudly when trying to package files that aren't included in the install.

There is also a typo/bug this patch fixes.

here is the patch...

--- /usr/src/packages/SPECS/sysstat-5.1.3.spec 2004-11-19 08:44:06.000000000 -0800

+++ /root/sysstat-5.1.3.spec 2004-12-16 13:57:30.206736256 -0800

@@ -33,7 +33,7 @@ make PREFIX=%{_prefix} \

%install

rm -rf $RPM_BUILD_ROOT

-install -d $RPM_BUILD_ROOT{/var/log/sa}

+install -d $RPM_BUILD_ROOT/var/log/sa

make IGNORE_MAN_GROUP=y \

DESTDIR=$RPM_BUILD_ROOT \

@@ -59,7 +59,7 @@ rm -rf $RPM_BUILD_ROOT

%files

%defattr(644,root,root,755)

-%doc CHANGES CREDITS README *.sample TODO FAQ

+%doc %{_prefix}/doc/sysstat*/*

%attr(755,root,root) %{_bindir}/*

%attr(755,root,root) %{_libdir}/sa/*

%attr(644,root,root) %{_mandir}/man*/*

16 Dec 2004 11:37 go_jesse

compile errors on 2.6
Hey, just tried to do an rpmbuild --rebuild on 5.1.3

noticed that the build failed because MAX_BLKDEV isn't defined for 2.6 kernels, for some reason it was removed from major.h.

I defined it to 255 on the command line, and the compile finished. sar doesn't work, but I have yet to actually install it, so that will probably help.

Screenshot

Project Spotlight

ReciJournal

An open, cross-platform journaling program.

Screenshot

Project Spotlight

Veusz

A scientific plotting package.